Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 2 | Form-Control#1184
Birmingham | 26-ITP-Jan | Mohammed Omer | Sprint 2 | Form-Control#1184mo-omer wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mo-omer
added
the
Needs Review
hkavalikas
added
Review in progress
Form-Controls/index.html
Outdated
| </main> | ||
|
|
||
| <footer> | ||
| <p>Website Dedicated To T-shirt Sale</p> |
There was a problem hiding this comment.
We had slightly different requirements for the content of this footer. Let's check the edited files again and address it.
| </p> | ||
| </section> | ||
|
|
||
| <!-- Colour Selection --> |
There was a problem hiding this comment.
Let's look into the colour selection a bit more, specifically the options. Do you see anything that might look off and not fulfil the requirements?
Form-Controls/index.html
Outdated
| Red | ||
| </label> | ||
|
|
||
| <p> |
There was a problem hiding this comment.
We are wrapping radio buttons into paragraphs, which might be a better fit for text. Can you find a more appropriate tag to wrap them instead?
Form-Controls/index.html
Outdated
| </div> | ||
|
|
||
| <label> | ||
| <input type="radio" name="colour" value="red" required /> |
There was a problem hiding this comment.
This radio button was declared in a slightly different way than others, it's not getting the CSS changes and doesn't fulfil the original requirements to be associated with the input. How can we improve it?
hkavalikas
added
Reviewed
|
Let's also improve the |
mo-omer
added
Needs Review
2 participants
Self checklist
Changelist
included semantic wrappers for better grouping form controls and simpler code.